Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows SDK upgrade #344

Closed
tymlipari opened this issue Feb 17, 2022 · 1 comment
Closed

Windows SDK upgrade #344

tymlipari opened this issue Feb 17, 2022 · 1 comment
Labels
Milestone

Comments

@tymlipari
Copy link
Contributor

For questions, please use the forum.

Describe the bug
The latest Github Actions agents for Windows no longer have the 10.0.18362.0 SDK available as it's several major versions behind. The related projects should be updated to target a newer version of the Windows SDK. Unfortunately upstream dependencies from react-native-windows (at least for 0.64) also include VS projects targeting that same build number.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repository for Windows
  2. Ensure the 18362 SDK is uninstalled and a newer version is installed
  3. Observe the React Native build fail when running npm run windows for the Playground project targeting 0.64.

Suggested fix
For 0.64 it's unlikely RNW will update their package, but the CI builds can be scripted to scan all of the *.vcxproj files referenced (including those from npm modules) from the solution file and update their <WindowsTargetPlatformVersion/> elements to target a newer SDK version. This will have no runtime impact as all Windows SDKs are backwards compatible, but will allow the project to build with later SDKs.

@tymlipari tymlipari added bug Something isn't working UWP labels Feb 17, 2022
@bghgary bghgary removed the bug Something isn't working label Apr 5, 2022
@thomlucc thomlucc added this to the Future milestone Sep 29, 2022
@bghgary
Copy link
Contributor

bghgary commented Apr 16, 2024

Duping with #507

@bghgary bghgary closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants