Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible compiler flag requirement. #90

Closed
TeachRaccooon opened this issue Apr 18, 2024 · 2 comments
Closed

Possible compiler flag requirement. #90

TeachRaccooon opened this issue Apr 18, 2024 · 2 comments

Comments

@TeachRaccooon
Copy link
Contributor

TeachRaccooon commented Apr 18, 2024

After the update of RandLAPACK to the newest version of RandBLAS (172d096) and attempting to compile it on ISAAC using gcc version 8.5.0 20210514, I ran into the following compilation error:

In file included from /nfs/home/mmelnic1/randlibs/RandLAPACK_ICQRRP/RandBLAS/test/test_rng_speed.cc:4:
/nfs/home/mmelnic1/randlibs/RandLAPACK_ICQRRP/RandBLAS/RandBLAS/../RandBLAS/base.hh:81:1: error: ‘concept’ does not name a type
 concept SignedInteger = (std::numeric_limits<T>::is_signed && std::numeric_limits<T>::is_integer);
 ^~~~~~~
/nfs/home/mmelnic1/randlibs/RandLAPACK_ICQRRP/RandBLAS/RandBLAS/../RandBLAS/base.hh:81:1: note: ‘concept’ only available with -fconcepts
make[2]: *** [RandBLAS/test/CMakeFiles/test_rng_speed.dir/build.make:76: RandBLAS/test/CMakeFiles/test_rng_speed.dir/test_rng_speed.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:167: RandBLAS/test/CMakeFiles/test_rng_speed.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

This issue did not occur when I ran the code locally on Elephant with gcc version 11.4.0.
This suggests that when working with some compilers, we are to add the '-fconcepts' flag into this file as:

# Add the -fconcepts flag
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fconcepts")

Adding the flag resolved the error, compilation succeeded.

@rileyjmurray
Copy link
Contributor

I've updated our installation guide to reference this issue. I'll leave this open since there's a natural opportunity for us to detect the need for this ourselves with CMake-foo.

@rileyjmurray
Copy link
Contributor

This should no longer be needed. I've used some now-standard preprocessor directives to make concepts optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants