Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of Selected Cards #308

Open
codeguru42 opened this issue Sep 8, 2014 · 11 comments
Open

Number of Selected Cards #308

codeguru42 opened this issue Sep 8, 2014 · 11 comments
Assignees
Milestone

Comments

@codeguru42
Copy link
Member

Show the number of selected cards in the CAB.

@codeguru42 codeguru42 modified the milestone: 0.6.5 Jan 25, 2016
@codeguru42 codeguru42 modified the milestones: 0.6.5, 0.6.6 Sep 6, 2016
@codeguru42 codeguru42 modified the milestones: 0.6.6, 0.8 Sep 26, 2016
@jojonarte
Copy link
Contributor

What's a CAB

@codeguru42
Copy link
Member Author

CAB is the Contextual Action Bar. This replaces the default Action Bar when items are selected in the list. See https://developer.android.com/design/patterns/actionbar.html for an overview.

@jojonarte
Copy link
Contributor

I'll check on this when i get some free time.

@jojonarte
Copy link
Contributor

hi @codeguru42 I couldn't seem to run the app after merging changes from devel/android.

@codeguru42
Copy link
Member Author

@jojonarte What branch did you merge devel/android into? What errors do you get when you run the app? Please provide the details and push your branch to your own GitHub fork. I can take a look at it from there.

@jojonarte
Copy link
Contributor

@codeguru42 it's on my own fork's devel/android, I pulled it from the bbct devel/android.
Error is :
Failed to resolve: support-core-utils

@jojonarte
Copy link
Contributor

should I rebase to the androidx? @codeguru42

@jojonarte
Copy link
Contributor

Should it look like below?
screen shot 2019-02-06 at 10 14 03 am

@codeguru42
Copy link
Member Author

Yes, that looks good. Can you also add "Card Selected" or "Cards Selected" after the number?

@jojonarte
Copy link
Contributor

@codeguru42 okay, btw do you have an existing test on CAB that I could look into?

@codeguru42
Copy link
Member Author

codeguru42 commented Feb 6, 2019

There are several tests for selecting cards. There should be a test for deleting a card as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants