Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-builder/validation): allow async validation #26

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

hpierre74
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6e45515). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8b4e51f differs from pull request most recent head 9c3457a. Consider uploading reports for the commit 9c3457a to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             master   #26   +/-   ##
======================================
  Coverage          ?     0           
======================================
  Files             ?     0           
  Lines             ?     0           
  Branches          ?     0           
======================================
  Hits              ?     0           
  Misses            ?     0           
  Partials          ?     0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e45515...9c3457a. Read the comment docs.

@hpierre74 hpierre74 merged commit 9f7e11b into master Jan 10, 2022
@hpierre74 hpierre74 deleted the update-validation branch January 10, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants