Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview anomaly when toggling a custom DCP tone curve on and off with Selective Editing tools activated #7147

Open
waynesutton50 opened this issue Jul 22, 2024 · 1 comment
Labels
scope: GUI Changes to GUI, not core functionality type: bug Something is not doing what it's supposed to be doing

Comments

@waynesutton50
Copy link

Toggling the DCP Tone curve (Color Management > Input Profile) on and off when a Selective Editing tool has been added to a spot, progressively increases the brightness and contrast of the preview. The exported jpeg is normal.
Steps to reproduce:
-Open an image with a Neutral profile
-Load a DCP profile into: Color Management > Input Profile > Custom
-Activate Selective Editing, add any type of spot and activate for example the 'Color appearance' tool.
-Return to the Input Profile menu and toggle the DCP tone curve on and off.

The image will become progressively brighter and the contrast will increase. Switching to the 'Camera standard' profile and back again will reset the preview.
The anomaly occurs also in the 5.10 release.

@Desmis
Copy link
Collaborator

Desmis commented Jul 23, 2024

@waynesutton50

Thank you for reporting this old malfunction which dates back at least 5.9

In the PR #7111 , I made a modification to the "events" using DCP. I think this should work better.

They (events) are all at "ALLNORAW" except those in question here with "RGBCURVE | M_AUTOEXP" - the same as for Selective Editing.
I made a change in refreshmap.cc
ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPToneCurve, 21 july 2024
ALLNORAW, // EvDCPIlluminant,
and
ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPApplyLookTable, 21 july 2024
ALLNORAW, //RGBCURVE | M_AUTOEXP, // EvDCPApplyBaselineExposureOffset, 21 july 2024
ALLNORAW, // EvDCPApplyHueSatMap

The problem seems to be fixed - to verify.

Jacques

@Lawrence37 Lawrence37 added type: bug Something is not doing what it's supposed to be doing scope: GUI Changes to GUI, not core functionality labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: GUI Changes to GUI, not core functionality type: bug Something is not doing what it's supposed to be doing
Projects
None yet
Development

No branches or pull requests

3 participants