Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while computing minimum raw value of Canon Dual Pixel image #7213

Open
Lawrence37 opened this issue Oct 7, 2024 · 1 comment
Open
Labels
scope: file format Camera or image file formats type: bug Something is not doing what it's supposed to be doing
Milestone

Comments

@Lawrence37
Copy link
Collaborator

Attempting to load a Canon Dual Pixel raw image results in a crash in dev.

This happens during the computation of the minimum raw value, which is used for raw de-haze. In this line, rawData is empty, so attempting to get the pixel value fails.

m0 = rtengine::min(m0, rawData[row][col] - cb0);

I used an image obtained from raw.pixls.us. The web page is down, and I can't upload the image because I don't remember the license for this particular file.

@Lawrence37 Lawrence37 added type: bug Something is not doing what it's supposed to be doing scope: file format Camera or image file formats labels Oct 7, 2024
@Lawrence37 Lawrence37 added this to the v5.12 milestone Oct 7, 2024
@Weltherrscher
Copy link

Weltherrscher commented Oct 7, 2024

I could provide some examples. Give the sun some time to settle, then i shoot 2..3 pictures.
//Edit:
image
No Crash on my end.
Compiled the latest git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: file format Camera or image file formats type: bug Something is not doing what it's supposed to be doing
Projects
None yet
Development

No branches or pull requests

2 participants