From a63d2395f020fcf2f2292ad292d4e3e1c68b6c5c Mon Sep 17 00:00:00 2001 From: Antoine Aflalo <197810+Belphemur@users.noreply.github.com> Date: Wed, 28 Aug 2024 11:51:06 -0400 Subject: [PATCH] fix(webp): better handling of error for page too big for webp --- converter/webp/webp_converter.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/converter/webp/webp_converter.go b/converter/webp/webp_converter.go index 2fb64b2..f89c2cd 100644 --- a/converter/webp/webp_converter.go +++ b/converter/webp/webp_converter.go @@ -17,6 +17,8 @@ import ( "sync/atomic" ) +const webpMaxHeight = 16383 + type Converter struct { maxHeight int cropHeight int @@ -202,6 +204,9 @@ func (converter *Converter) checkPageNeedsSplit(page *manga.Page) (bool, image.I bounds := img.Bounds() height := bounds.Dy() + if height >= converter.maxHeight { + return false, img, format, fmt.Errorf("page[%d] height %d exceeds maximum height %d of webp format", page.Index, height, converter.maxHeight) + } return height >= converter.maxHeight, img, format, nil }