Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Buffer size miscalcualtion for Zcash #11

Open
argjv opened this issue Sep 19, 2018 · 1 comment
Open

Buffer size miscalcualtion for Zcash #11

argjv opened this issue Sep 19, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@argjv
Copy link
Contributor

argjv commented Sep 19, 2018

Transaction.prototype.__toBuffer creates a buffer bigger than expected which we end up slicing.
We are doing some miscalculation somewhere, we shouldn't have to slice the final buffer.

@argjv argjv added the good first issue Good for newcomers label Sep 19, 2018
@karelbilek
Copy link

I think this is already fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants