FastLogin incompatible on Bungee-like systems

[Laurenshup]

The issue has been reported at:
games647/FastLogin#516

[Laurenshup]

I am in need of more information about this issue. BotSentry is definitely cancelling the PreLoginEvent of BungeeCord. FastLogin should not do any checks.

[SrBedrock]

If you need any information like log let me know, I will try to help as much as possible

[Laurenshup]

If you need any information like log let me know, I will try to help as much as possible

Any logs are welcome. Also can you say which version of BotSentry you are using?

[SrBedrock]

[SrBedrock]

Logs: https://mclo.gs/4ugqi3b

[Laurenshup]

@SrBedrock Can you give me the line number in which you think the attack started?

[SrBedrock]

It was already occurring, the log is after a restart to disable a plugin that was causing problems, they will probably solve the problem soon so I hope. If you want the previous logs let me know, but the server was inaccessible due to the amount of requests with the mojang and database by the anti-vpn system.

[Laurenshup]

So. BotSentry did not have any problems with FastLogin? Because it does not seem so.

[games647]

I am in need of more information about this issue. BotSentry is definitely cancelling the PreLoginEvent of BungeeCord. FastLogin should not do any checks.

@Laurenshup Is your plugin performing the checks asynchronous. Then setting the cancelled state could occur after the event already fired for other plugins.

[Laurenshup]

@Laurenshup Is your plugin performing the checks asynchronous. Then setting the cancelled state could occur after the event already fired for other plugins.

Nope, the plugin checks both synchronous/asynchronous. But inside of the PreLoginEvent, it always does the basic checks (checking if IP is in blacklist, etc.) synchronous therefore it also sets the cancelled state synchronous.

[Laurenshup]

Some updates about this issue. The API in the upcoming versions, will use CompletableFuture, allowing for thread-blocking on PreLoginEvent by other plugins. This will help them to check for the BotSentry status first.

Further it seems like FastLogin uses the normal Priority on Bungee. BotSentry uses the lowest, meaning, BotSentry will come first.

[Laurenshup]

A customer, has experienced this bug. And the best way to solve this problem is by directly implementing into the FastLoginBungee API.