From cb807fd78aad3482153bda6b974a1b515130f7ea Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Sat, 24 Aug 2024 08:24:41 +0200 Subject: [PATCH 1/3] Makefile.mk: Remove Wno-trigraphs commit Ia219ccc added -Wno-trigraphs to let unit-tests builds. Change-Id: Ibfe47194daafc02f89c83f045fb73c99a7c86d5d Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/83453 Reviewed-by: coreboot org Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) --- Makefile.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.mk b/Makefile.mk index 4a2f1918acd..18ec01af490 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -515,7 +515,6 @@ CFLAGS_common += -Wstrict-prototypes CFLAGS_common += -Wmissing-prototypes CFLAGS_common += -Wwrite-strings CFLAGS_common += -Wredundant-decls -CFLAGS_common += -Wno-trigraphs CFLAGS_common += -Wimplicit-fallthrough CFLAGS_common += -Wshadow CFLAGS_common += -Wdate-time From 41663cf9cb727f6a60333fec50ef871d4ef52b83 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Sat, 12 Oct 2024 18:06:19 +0200 Subject: [PATCH 2/3] payloads/libpayload: Remove Wno-trigraphs Change-Id: I2a0ba493da327353c7489b471d4de91db30b8fc5 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/84754 Tested-by: build bot (Jenkins) Reviewed-by: Jakub Czapiga --- payloads/libpayload/Makefile.mk | 2 +- payloads/libpayload/tests/Makefile.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/payloads/libpayload/Makefile.mk b/payloads/libpayload/Makefile.mk index 6dd33e11974..c9cefb31eca 100644 --- a/payloads/libpayload/Makefile.mk +++ b/payloads/libpayload/Makefile.mk @@ -78,7 +78,7 @@ CFLAGS += $(INCLUDES) -Os -pipe -nostdinc -ggdb3 CFLAGS += -nostdlib -fno-builtin -ffreestanding -fomit-frame-pointer CFLAGS += -ffunction-sections -fdata-sections CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wvla -CFLAGS += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough +CFLAGS += -Wwrite-strings -Wredundant-decls -Wimplicit-fallthrough CFLAGS += -Wstrict-aliasing -Wshadow -Werror ifeq ($(CONFIG_LP_LTO),y) diff --git a/payloads/libpayload/tests/Makefile.mk b/payloads/libpayload/tests/Makefile.mk index 71189068507..01f0a9ec8d1 100644 --- a/payloads/libpayload/tests/Makefile.mk +++ b/payloads/libpayload/tests/Makefile.mk @@ -44,7 +44,7 @@ TEST_CFLAGS += -I$(cmockasrc)/include # Minimal subset of warnings and errors. Tests can be less strict than actual build. TEST_CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wvla -TEST_CFLAGS += -Wwrite-strings -Wno-trigraphs -Wimplicit-fallthrough +TEST_CFLAGS += -Wwrite-strings -Wimplicit-fallthrough TEST_CFLAGS += -Wstrict-aliasing -Wshadow -Werror TEST_CFLAGS += -Wno-unknown-warning-option -Wno-source-mgr -Wno-main-return-type From 1890bd6117ecb6059d694b383db4d0dbcfdf0986 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Sat, 12 Oct 2024 18:09:30 +0200 Subject: [PATCH 3/3] tests/Makefile.common: Remove Wno-packed-not-aligned flag Change-Id: Id0f0d309aa7d208298e8aaf77d6c5042570547e0 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/84755 Tested-by: build bot (Jenkins) Reviewed-by: Jakub Czapiga --- tests/Makefile.common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.common b/tests/Makefile.common index e856fe07c13..dd7cca29f40 100644 --- a/tests/Makefile.common +++ b/tests/Makefile.common @@ -48,7 +48,7 @@ TEST_INCLUDES += -I$(dir $(TEST_KCONFIG_AUTOHEADER)) # unintentional. TEST_CFLAGS += -Wall -Werror -Wundef -Wstrict-prototypes -Wno-inline-asm TEST_CFLAGS += -Wno-unknown-warning-option -Wno-source-mgr -Wno-main-return-type -TEST_CFLAGS += -Wno-array-compare -Wno-packed-not-aligned -Wno-trigraphs +TEST_CFLAGS += -Wno-array-compare -Wno-trigraphs TEST_CFLAGS += -Wno-unused-but-set-variables TEST_CFLAGS += -std=gnu11 -ffunction-sections -fdata-sections -fno-builtin