Linux: some image assets missing from appimage build

[cibomahto]

The Welcome Screen images are missing from the linux app image:

For reference, this is what it should look like:

[probonopd]

Should be a matter of copying the assets to the correct place... let me know if you'd like help from my side on this.

[probonopd]

How do you call these images in the code, in other words, where are they expected to be loaded from?

[cibomahto]

They are loaded from QUrl addresses during runtime, like this:

https://github.com/Blinkinlabs/PatternPaint/blob/master/PatternPaint/gui/scenetemplate.cpp
SceneTemplate sceneTemplates[SCENE_TEMPLATE_COUNT] = {
{
"BlinkyTape",
":/scenetemplates/images/scenetemplates/blinkytape.jpg",
":/examples/blinkytape",
"BlinkyTape",
"Linear",
RGB,
60,
1
},

https://github.com/Blinkinlabs/PatternPaint/blob/master/PatternPaint/gui/welcomescreen.cpp
for (int i = 0; i < SCENE_TEMPLATE_COUNT; i++) {
QListWidgetItem *item = new QListWidgetItem(sceneTemplates[i].name, ui->SceneList);
item->setIcon(QIcon(sceneTemplates[i].photo));
}

and they are listed in a qrc file:
https://github.com/Blinkinlabs/PatternPaint/blob/master/PatternPaint/images.qrc
https://github.com/Blinkinlabs/PatternPaint/tree/master/PatternPaint/images/scenetemplates

[probonopd]

The : in the example above means that QDir::searchPaths is used.

The images are part of the AppImage, e.g., in images/scenetemplates/blinkytape.jpg. The way I read https://github.com/Blinkinlabs/PatternPaint/tree/master/PatternPaint/images/scenetemplates this sould be correct... but running strace shows something suspicious:

[pid  3453] open("/tmp/.mount_knewpk/plugins/platforms/../../lib/libxcb-image.so.0", O_RDONLY|O_CLOEXEC <unfinished ...>
[pid  3453] stat("/tmp/.mount_knewpk/plugins/imageformats/.",  <unfinished ...>

Looks like plugins/imageformats/* needs to be deployed but isn't. Opened an issue with linuxdeployqt:
probonopd/linuxdeployqt#53

[cibomahto]

I expected them to be embedded in the executable, as that's how they are built on Windows and macOs. Following:
https://doc.qt.io/qt-5/resources.html

I can see that they are pulled into a temp file 'qrc_images.cpp', at least during a normal qmake build on our internal CI server. It's a little interesting that the program icons and other resources should be using the same loading method, but seem to be present in the build.

[probonopd]

I can confirm that I have identified the root cause and fixed it in probonopd/linuxdeployqt@4951fd1 (an else was missing there).

Here is a working AppImage:
https://transfer.sh/JMRDB/patternpaint-git2.0.4-50-g6754f12-x86-64.appimage
Build log:
https://travis-ci.org/probonopd/PatternPaint#L1163

I will send a PR once some cleanup on my side is done.