Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround fcntl and dbus_fast not available on windows #102

Merged
merged 8 commits into from
Dec 16, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 16, 2023

fixes #101

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0e9bc85) 91.90% compared to head (0acf97c) 91.89%.

Files Patch % Lines
src/bluetooth_adapters/systems/linux_hci.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   91.90%   91.89%   -0.01%     
==========================================
  Files          13       13              
  Lines         457      469      +12     
  Branches       80       81       +1     
==========================================
+ Hits          420      431      +11     
- Misses         30       31       +1     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco changed the title fix: workaround fcntl not available on windows fix: workaround fcntl and dbus_fast not available on windows Dec 16, 2023
@bdraco
Copy link
Member Author

bdraco commented Dec 16, 2023

usb_devices has the same issue.

need to solve that first.

@bdraco bdraco marked this pull request as draft December 16, 2023 09:45
@bdraco bdraco marked this pull request as ready for review December 16, 2023 20:22
@bdraco bdraco merged commit 0c48649 into main Dec 16, 2023
12 of 14 checks passed
@bdraco bdraco deleted the windows branch December 16, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import get_adapters on Windows due to fcntl module not available
1 participant