Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't import from dbus module on Windows #57

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: Don't import from dbus module on Windows #57

merged 1 commit into from
Apr 3, 2023

Conversation

koenvervloesem
Copy link
Contributor

Currently importing from Bluetooth Adapters on Windows results in an error because the dbus module is imported. This PR changes the import to a conditional one depending on the operating system. Fixes #56

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.25 ⚠️

Comparison is base (67d4d35) 97.92% compared to head (3918166) 97.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   97.92%   97.68%   -0.25%     
==========================================
  Files          12       12              
  Lines         386      388       +2     
  Branches       67       46      -21     
==========================================
+ Hits          378      379       +1     
  Misses          6        6              
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/bluetooth_adapters/__init__.py 91.66% <66.66%> (-8.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit f936758 into Bluetooth-Devices:main Apr 3, 2023
@bdraco
Copy link
Member

bdraco commented Apr 3, 2023

Thanks @koenvervloesem

@koenvervloesem koenvervloesem deleted the no_dbus_on_windows branch April 3, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing on Windows systems results in an AttributeError
2 participants