-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out Albino for Pygments #50
Comments
I was just submitting a PR when I noticed that this issue already existed :) I did this because Albino won't work on Heroku due to the python package dependency. It's working nicely with it now for me so far. The only hacky thing is that this gem wants the lexer extension to be passed as a symbol, so I cast it. Since both gems are using the Pygments lexers, I would imagine they always have the same names, so it theoretically should not change anything for anyone. I did notice some additional parsing with this gem. For example, the bash keywords (e.g. |
@natchiketa Thanks! I think a more flexible solution would be to create a new class for each syntax highlighting solution. Have a look at the Markdown parser If we can add a new class for the Albino renderer in Thoughts? |
I absolutely agree with that approach. I'll try to submit a PR doing it that way this week. I was going to hold off until I could submit it doing it that way, but when I saw this issue (i.e. that you wanted to just swap them out) I thought I'd go ahead and do one the way I have it currently. But yeah, even if it was just one, I would still agree it should be structured the way you're suggesting. |
See the comments on this pull request
The text was updated successfully, but these errors were encountered: