Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fonts in editor #125

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fix/fonts in editor #125

merged 2 commits into from
Sep 9, 2019

Conversation

rramo012
Copy link
Member

@rramo012 rramo012 commented Sep 4, 2019

Fixes an issue that prevents the fonts from rendering correctly in both gutenberg and the post and page builder.

The first change allows us to bypass a conditional within the Kirki output class which will skip output unless explicitly requested in the context. The second change pulls in bgtfw dynamic styles in the tinymce context.

Testing:

  • Load the post and page builder with a custom font family for the body. Should be wysiwyg
  • Load gutenberg with a custom font family for the body. Should be wysiwyg

@rramo012 rramo012 self-assigned this Sep 4, 2019
@timelsass timelsass merged commit 5d62209 into dev Sep 9, 2019
@jamesros161 jamesros161 deleted the fix/fonts-in-editor branch April 21, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants