Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previewing bgtfw based themes fails to load google fonts #155

Closed
timelsass opened this issue Jan 12, 2020 · 2 comments
Closed

previewing bgtfw based themes fails to load google fonts #155

timelsass opened this issue Jan 12, 2020 · 2 comments
Labels
bug General bug issues

Comments

@timelsass
Copy link
Member

While demoing available themes, a user went into crio theme and was changing various options before applying the theme in "live Preview" mode in the customizer. When visiting the fonts sections, the google fonts list fails to populate, and the user thought the theme didn't have any customization options for fonts:

image

The list does show up if the changes are applied and saved, and the customizer is refreshed with crio as the active theme. I believe this has been fixed in latest version of the control from kirki.

there are a couple of 404s on the ajax reqs and was followed by this console error:

script.min.js?ver=3.0.38:1 Uncaught TypeError: Cannot read property 'Open Sans' of undefined
    at Object.getFontType (script.min.js?ver=3.0.38:1)
    at i.renderBackupFontSelector (script.min.js?ver=3.0.38:1)
    at initKirkiControl (script.min.js?ver=3.0.38:1)
    at Object.<anonymous> (script.min.js?ver=3.0.38:1)
    at i (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate&ver=5.3.2:2)
    at Object.fireWith [as resolveWith] (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate&ver=5.3.2:2)
    at Object.e.<computed> [as resolve] (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate&ver=5.3.2:2)
    at i.actuallyEmbed (script.min.js?ver=3.0.38:1)
    at Function.<anonymous> (script.min.js?ver=3.0.38:1)
    at i (load-scripts.php?c=1&load[chunk_0]=jquery-core,jquery-migrate&ver=5.3.2:2)
@rramo012 rramo012 added the bug General bug issues label Mar 11, 2020
@jamesros161
Copy link
Contributor

Unable to replicate issue. This was likely resolved in the latest version of Kirki as noted in Tim's notes

@nicolepaschen
Copy link
Member

Have 2020 Active
Appearance > Add themes > Search for Crio
Click Live Preview
The Starter Content will show with the Crio Customizer
Click on Fonts > Main Text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug issues
Projects
None yet
Development

No branches or pull requests

4 participants