[PW3]: padding a macro argument shown twice

[jonpas]

warning[PW3]: padding a macro argument
   ┌─ addons/shootingrange/functions/fnc_create.sqf:89:99
   │
89 │     ERROR_1("Invalid triggers in Trigger Markers! Make sure all triggers are correctly set! (%1)", _name);
   │                                                                                                   ^ padding a macro argument
   │
   = note: padding a macro argument is likely unintended
   = note: occured in: `ERROR_1`


warning[PW3]: padding a macro argument
   ┌─ addons/shootingrange/functions/fnc_create.sqf:89:99
   │
89 │     ERROR_1("Invalid triggers in Trigger Markers! Make sure all triggers are correctly set! (%1)", _name);
   │                                                                                                   ^ padding a macro argument
   │
   = note: padding a macro argument is likely unintended
   = note: occured in: `FORMAT_1`

[BrettMayson]

Not able to create a MRE, will need to confirm this is still occuring on the next release.

This currently only produces a single error for me

#include "script_macros_common.hpp"

ERROR_1("Invalid triggers in Trigger Markers! Make sure all triggers are correctly set! (%1)", _name);

[jonpas]

I'll give it another test on latest.

[jonpas]

Still happens twice at https://github.com/Theseus-Aegis/Mods/blob/943906d18817a7f0829742f0c91cdad34456c594/addons/shootingrange/functions/fnc_create.sqf#L89 on 2fd248b

You can see it in CI as well: https://github.com/BrettMayson/HEMTT/actions/runs/7953825250/job/21710390932#step:8:5080

[Eathox]

Also ran into this and took a quick look around, and frankly getting lost in the code base (wont be making a PR 😅).
However I did spot a bug in the tests which hides the warning, at:

HEMTT/libs/preprocessor/tests/warnings.rs

Lines 40 to 46 in cf8d577

	let warning = config
	.warnings()
	.first()
	.unwrap()
	.diagnostic()
	.unwrap()
	.to_string(&WorkspaceFiles::new());

Changing that to something along the lines of:

let warning = config
    .warnings()
    .iter()
    .map(|w| w.diagnostic().unwrap().to_string(&WorkspaceFiles::new()))
    .collect::<String>();

Makes the example posted by Brett also spit out this warning.