jprouse/US153861-double-spaces-rule

[JakeProuse]

Rally Story: https://rally1.rallydev.com/#/?detail=/userstory/704556573471&fdp=true

Hi Gaudi, we are adding the no-multi-spaces rule to one of our repos and thought to check here and see if this is something useful for any of the existing configs (we currently use the browser-config a lot). We're aiming to avoid making custom rules in the eslint files in all our projects but no harm if this isn't desired 😄

[AntonBazhal]

I'm personally a fan of this rule

[dlockhart]

This makes sense to me, although should it maybe go in common-config.js? We likely want it in both browser-based JS and Node.js.

[JakeProuse]

I know this would likely set off linters around brightspace, would this be a big enough change for a major version or do you often just make minor updates and expect repos to make updates?

[dlockhart]

would this be a big enough change for a major version or do you often just make minor updates and expect repos to make updates?

So NPM versions (really semantic versioning) has this weird thing where when you're at 0.x like this library is, minor version bumps are actually treated as major. So ^0.1 won't automatically install 0.2 vs. ^1 would install 1.1, 1.2, etc.

[JakeProuse]

would this be a big enough change for a major version or do you often just make minor updates and expect repos to make updates?

So NPM versions (really semantic versioning) has this weird thing where when you're at 0.x like this library is, minor version bumps are actually treated as major. So ^0.1 won't automatically install 0.2 vs. ^1 would install 1.1, 1.2, etc.

Ah so if this PR gets merged I should add feat: in the commit message so we get a minor / pseudo-major version bump?

[dlockhart]

Exactly, yeah.

[JakeProuse]

@dlockhart Is this good to merge? Wasn't sure how many checks we wanted!

[dlockhart]

Yep, go for it! Squash-merge with feat: <description> in the merge commit.

[ghost]

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀