Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional lit lifecycle methods #62

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

EvanLemieux
Copy link
Contributor

We're making use of willUpdate in folio-app and noticed that our linting config doesn't treat it as a lit lifecycle method. Adding a few others from the documentation while I'm here.

@EvanLemieux EvanLemieux requested a review from a team as a code owner October 19, 2023 20:02
Copy link

@eKoopmans eKoopmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Evan!

Copy link
Collaborator

@dbatiste dbatiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks! 😄

@EvanLemieux EvanLemieux merged commit 348523f into main Oct 19, 2023
@EvanLemieux EvanLemieux deleted the elemieux/add-additional-lit-lifecycle-methods branch October 19, 2023 20:26
@ghost
Copy link

ghost commented Oct 19, 2023

🎉 This PR is included in version 0.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants