Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactoring suggestions #132

Open
Remi-Gau opened this issue Sep 14, 2023 · 1 comment
Open

Sourcery refactoring suggestions #132

Remi-Gau opened this issue Sep 14, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Remi-Gau
Copy link
Contributor

Sourcery made a bunch of refactoring suggestions on my fork.

You may want to have a look as some of them seem to make some nested conditionals quite a bit simpler.

https://github.com/Remi-Gau/brkraw/pull/1

@dvm-shlee
Copy link
Member

Hi @Remi-Gau,
Thank you for pointing out the refactoring suggestions made by Sourcery on my fork. I've taken a look and agree that they could significantly simplify some of the nested conditionals. I appreciate your proactive approach in highlighting this.

I plan to implement these suggestions in the upcoming update, which is scheduled for the next 2 to 3 weeks. Your input is invaluable, and I'm grateful for your contribution to enhancing the project's quality.

Thanks once again for your support and suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants