-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(worker-window): polyfill CSSMediaRule #614
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks like CI had an issue installing PNPM. Can a maintainer please rerun the CI checks on this PR? |
@gioboa Do you see any issues with adding this? |
It looks good to me but I'm no longer on the core team that maintains the library. I'm sorry. |
I discovered that microsoft clarity has patched this on their end and I'm not sure this solution makes sense as it only polyfilled the bare minimum of what was needed so I'm going to close for now. |
In the end, this should still go in. It wasn't patched in clarity and having this polyfilled inside partytown is arguably a better solution. |
I'm still having this issue with clarity, I think it's a good idea to merge this |
What is it?
Description
Include polyfill for
CSSMediaRule
(used by hubspot tracking js)Use cases and why
Hubspot references CSSMediaRule in their JS and it is currently failing because it doesn't exist in worker context.
We already have the polyfill for CSSStyleSheet and CSSMediaRule has the same interface so the same polyfill should work!
Checklist: