Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance adding urls in video collection template #376

Open
jainkuniya opened this issue Jan 3, 2017 · 5 comments
Open

Enhance adding urls in video collection template #376

jainkuniya opened this issue Jan 3, 2017 · 5 comments

Comments

@jainkuniya
Copy link
Contributor

Observed Behaviour
To add items we have to enter link in the dialog.

Issue
It is difficult to copy url's and paste in the dialog.

Solution
Use CustomTabs

Approach
Add a Browse button in the dialog. On clicking that open CustomTabs with action button Add this video. On clicking this action (Add this video) video will be added in the template.

buildmlearn customtabs issue video

@yadav-rahul
Copy link
Contributor

@opticod @croozeus I would like to work on this. Shall I proceed?

@jainkuniya
Copy link
Contributor Author

Thanks @yadav-rahul for your interest in this. I have done some part of it.

@croozeus @opticod waiting for your views on this. Shall I continue work on this and create PR?

@opticod
Copy link
Collaborator

opticod commented Feb 26, 2017

@vishwesh3, Its a real issue. We should fix this. Lets discuss the implementation a bit and choose the best one:

What will be next step after you click the "Add this video" ?

@jainkuniya
Copy link
Contributor Author

We will add menu item with

intentBuilder.addMenuItem(label, pendingIntent);

where label is Add this video

and pendingIntent is a intent to BroadcastReceiver.

This BroadcastReceiver, onReceive will get url of the video.

So when Add this video is clicked Receiver will be called and we can get the url of the video through intent, then we can interact between receiver and activity in order to get url in activity.

Something like this.

ezgif com-video-to-gif 6

In this sample I am showing toast on selecting Add this video, in our toolkit app, will add selected video in our list.

Also in sample I have used Hello button to launch custom tab, in our toolkit app we can show a button at the right of the editText of entering url.

screenshot_20170226-205245

on clicking above button we can show a dialog containg list of all sites whose videos are supported in our app (youtube, vimeo, dailymotion), and on selecting this option launch customtab with selected site.

@opticod should I proceed with this?

@opticod
Copy link
Collaborator

opticod commented Sep 29, 2017

Cool, you can proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants