Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: minHeight not working #35

Closed
kinow opened this issue Jun 1, 2021 · 2 comments
Closed

bug: minHeight not working #35

kinow opened this issue Jun 1, 2021 · 2 comments
Assignees

Comments

@kinow
Copy link

kinow commented Jun 1, 2021

Version
Version 0.5.2

Describe the bug

Tried array and object configuration, in both the minHeight set to 0 or 1 is ignored. It keeps using the default value of 200 no matter the value I pass.

To Reproduce

I used the following configuration:

module.exports = {
  plugins: {
    'demo-code': {
      showText: 'show code',
      hideText: 'hide',
      minHeight: 0,
      onlineBtns: {
        codepen: false,
        jsfiddle: false,
        codesandbox: false,
      }
    }
  }
}

Expected behavior

minHeight set to 0 (or any value provided by the user)

Additional context

Thanks!

@kinow kinow added the bug Something isn't working label Jun 1, 2021
@kinow kinow mentioned this issue Jun 1, 2021
6 tasks
@BuptStEve
Copy link
Owner

image

Can't reproduce, maybe you should save your *.md file to trigger render.

@BuptStEve BuptStEve removed the bug Something isn't working label Jun 5, 2021
@kinow
Copy link
Author

kinow commented Jun 5, 2021

I first noticed it at $work laptop. And reported the issue from home laptop after seeing it again. Will try a codepen later to see if I can create a minimal example to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants