Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ headers: ["column1", "column2", ... ] } issue #168

Closed
HoosierMike opened this issue Dec 15, 2016 · 10 comments
Closed

{ headers: ["column1", "column2", ... ] } issue #168

HoosierMike opened this issue Dec 15, 2016 · 10 comments

Comments

@HoosierMike
Copy link

When you use this syntax there is no way to set { headers: true } thus you get the first "data" block which is the headers and you have to add a cheesy flag to your code to ignore the first call to data() {}

@fdrobidoux
Copy link

fdrobidoux commented Feb 6, 2017

Getting the same problem. This should be a simple fix, however.

@dustinsmith1024
Copy link
Contributor

Makes sense. Feel free to submit a PR and we will merge it in.

@josemigallas
Copy link
Contributor

josemigallas commented Feb 16, 2017

Anyone already working on this? I'd like to give it a try

@fdrobidoux
Copy link

Go right ahead, champ.

@josemigallas
Copy link
Contributor

So PR sent, any chance of getting a review? 😁

@jefffriesen
Copy link

It would be great to get this merged.

@dustinsmith1024
Copy link
Contributor

It's merged, just the docs are waiting right?

@jefffriesen
Copy link

Yep, you're right.

@asabhaney
Copy link
Contributor

I've submitted a PR for the docs, it's ready to be merged in: #182

@jamesearl
Copy link

Still seeing the old behavior in fast-csv@^2.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants