Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Entire lodash is imported, bloating dependencies #281

Closed
depo34 opened this issue Sep 11, 2019 · 1 comment
Closed

[BUG] Entire lodash is imported, bloating dependencies #281

depo34 opened this issue Sep 11, 2019 · 1 comment
Assignees

Comments

@depo34
Copy link

depo34 commented Sep 11, 2019

Specific functions from lodash are being used, but because the entire library is being import-ed, bundlers like webpack are including all of lodash.

To Reproduce

  1. Pull fast-csv into a project that's built with webpack
  2. Look at webpack dependencies

Expected behavior
Only portions of lodash should be imported

E.g., import isString from 'lodash/isString';

Screenshots
E.g., import { isString } from 'lodash'; // Bundlers will bring all of lodash here

Desktop (please complete the following information):
n/a

Additional context
lodash/lodash#3192

@doug-martin
Copy link
Contributor

Fixed in v3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants