Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop support for unsupported versions of Node.js #833

Merged
merged 6 commits into from
Dec 27, 2023

Conversation

zackerydev
Copy link
Contributor

@zackerydev zackerydev commented Dec 19, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Have you added tests for the new feature
  2. Does your submission pass tests?
  3. Have you lint your code locally prior to submission?
  4. Have you updated the docs?
    • If you added new parsing or formatting options have you added them to the docs?
    • If applicable have you added an example to the parsing or formatting docs?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@c2fo-cibot c2fo-cibot bot added the size/L Denotes a PR that changes 100-499 lines label Dec 19, 2023
@c2fo-cibot c2fo-cibot bot added size/XL Denotes a PR that changes 500-999 lines and removed size/L Denotes a PR that changes 100-499 lines labels Dec 19, 2023
@zackerydev zackerydev self-assigned this Dec 19, 2023
@zackerydev
Copy link
Contributor Author

I did my best to change zero functional code here, I only changed:

  • Type Definitions
  • Linting Configs
  • Prettier
  • Type Definitions in Tests

This is obviously going to be a breaking change, but my hope is that I can start here and build up what we need to ship a 5.0

Copy link
Contributor

@dustinsmith1024 dustinsmith1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - thanks @zackerydev!

I would support turning off the short return syntax that caused all the formatting changes, but its not a big deal.

@c2fo-cibot c2fo-cibot bot added size/XXL Denotes a PR that changes 1000+ lines and removed size/XL Denotes a PR that changes 500-999 lines labels Dec 27, 2023
@zackerydev zackerydev merged commit b569da0 into master Dec 27, 2023
6 checks passed
@zackerydev zackerydev deleted the zackerydev/node-20-fast-csv branch December 27, 2023 18:37
@zackerydev zackerydev mentioned this pull request Dec 27, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants