Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate hard-coded configuration file from update script #24

Open
confluence opened this issue May 12, 2022 · 0 comments
Open

Eliminate hard-coded configuration file from update script #24

confluence opened this issue May 12, 2022 · 0 comments

Comments

@confluence
Copy link
Contributor

The update script should not use a hard-coded configuration file location for the update settings. This makes it impossible to integrate it with beta packages which have a custom config location without manual intervention from the user.

Ideally the script should not be doing this parsing at all. My suggestion would be to move this functionality into the CARTA backend, which should be able to locate its own configuration directory. The backend should check these settings and then possibly launch the script only if it is required. This would require changes to the backend so that it is able to access the frontend preferences file.

A simpler option would be to add a custom config file parameter to the existing script, and to patch the existing backend launcher script in the beta packages. I would prefer to eliminate the parsing component of the script entirely, but if we run out of time before the next release this could be a fallback solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant