Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses that are submitted in this format through CATcher will be rejected #483

Closed
JunWei96 opened this issue Oct 11, 2020 · 4 comments · Fixed by #484
Closed

Responses that are submitted in this format through CATcher will be rejected #483

JunWei96 opened this issue Oct 11, 2020 · 4 comments · Fixed by #484
Assignees

Comments

@JunWei96
Copy link
Contributor

JunWei96 commented Oct 11, 2020

For example, submit the following string as a team's response through CATcher. The response will not be registered as being responded in CATcher. This bug will probably also be present in other phases that uses regex.

# Team's Response
No response provided.

 ## Duplicate status (if any):
--
@JunWei96 JunWei96 changed the title Responses that are submitted in same format through CATcher will be rejected Responses that are submitted in this format through CATcher will be rejected Oct 11, 2020
@damithc
Copy link
Contributor

damithc commented Oct 11, 2020

There is no reason for this to happen 'accidentally' if a user is using CATcher right?
What if we allow a user to use the GitHub interface because she can't use CATcher for some reason? Would this issue cause a problem then?

@JunWei96
Copy link
Contributor Author

There is still a possibility. In fact, if the user submits in the following format through CATcher, CATcher will mark the issue as not responded too.

# Team's Response
test

If we allow a user to use Github interface then I suppose the user would need to submit their responses in the required format?

@damithc
Copy link
Contributor

damithc commented Oct 11, 2020

There is still a possibility. In fact, if the user submits in the following format through CATcher, CATcher will mark the issue as not responded too.

# Team's Response
test

But the user has no reason to type # Team's response right? Perhaps we should make the internal format such that it is not something a user will type 'accidentally.

e.g., # [[Team's Response]]

If we allow a user to use Github interface then I suppose the user would need to submit their responses in the required format?

Yes.

@JunWei96
Copy link
Contributor Author

I have made a PR to fix this. It is a simple fix that relaxes the rule on what is considered the "correct" format. So I don't think we need to change the internal format.

@JunWei96 JunWei96 self-assigned this Oct 11, 2020
@JunWei96 JunWei96 mentioned this issue Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants