Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Rust decoder not used for 708 captions on MPEG-TS files #1500

Closed
7 tasks done
ArchitBhonsle opened this issue Mar 15, 2023 · 1 comment
Closed
7 tasks done

[BUG] Rust decoder not used for 708 captions on MPEG-TS files #1500

ArchitBhonsle opened this issue Mar 15, 2023 · 1 comment

Comments

@ArchitBhonsle
Copy link
Contributor

ArchitBhonsle commented Mar 15, 2023

CCExtractor version: 0.94 (Build from master with cmake and no flags)

In raising this issue, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm porting isn't already solved and no duplicates exist in closed issues and in opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.
  • I have used the latest available version of CCExtractor to verify this issue exists.
  • I have ticked all the boxes in this section and to prove it I'm deleting the section completely to remove boilerplate text.

Necessary information

  • Is this a regression (i.e. did it work before)? Yes (I think this was supposed to work before)
  • What platform did you use? Linux
  • What were the used arguments? ./build/ccextractor ~/Downloads/CCExtractor/7236304cfcfce141c7cec31647c1268a3886063390ce43c2f71188c70f5494c4/video.ts -608 -708 -out=smi

Video links

https://sampleplatform.ccextractor.org/sample/7236304cfcfce141c7cec31647c1268a3886063390ce43c2f71188c70f5494c4

Additional Information

I'm pretty sure this is using the C decoder for 708. The reason I think this is C is because C does everything in uppercase while rust is in lowercase.

Command and logs
Subtitles produced

@marcybelardo
Copy link

I think in this case, C was showing up because there isn't an implementation for the 608 decoder in Rust yet.

Reproducing logs with same command
Command/logs with only 708 enabled

I believe even after the decoder for 708 is fixed, the C encoding will show up in stdout until 608 is ported to Rust too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants