From 898d7c55d6d0ed6f7179d921709cab8a66a1a0a1 Mon Sep 17 00:00:00 2001 From: David Gage Date: Mon, 21 Oct 2024 12:04:29 -0400 Subject: [PATCH] Close file handles --- upload-server/internal/delivery/file.go | 1 + upload-server/internal/loaders/file/file.go | 1 + 2 files changed, 2 insertions(+) diff --git a/upload-server/internal/delivery/file.go b/upload-server/internal/delivery/file.go index ab2b4fcc..ea09c81a 100644 --- a/upload-server/internal/delivery/file.go +++ b/upload-server/internal/delivery/file.go @@ -75,6 +75,7 @@ func (fd *FileSource) GetMetadata(_ context.Context, tuid string) (map[string]st } return nil, err } + defer f.Close() b, err := io.ReadAll(f) if err != nil { diff --git a/upload-server/internal/loaders/file/file.go b/upload-server/internal/loaders/file/file.go index 5c55adb3..c3ee802f 100644 --- a/upload-server/internal/loaders/file/file.go +++ b/upload-server/internal/loaders/file/file.go @@ -18,5 +18,6 @@ func (l *FileConfigLoader) LoadConfig(_ context.Context, path string) ([]byte, e if err != nil { return nil, errors.Join(err, validation.ErrNotFound) } + defer file.Close() return io.ReadAll(file) }