Fix -fsanitize=address bugs #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: ‘snprintf’ output between 21 and 31 bytes into a destination of size 30 The assembly test had inconsistent ordering of arguments between the qfunction itself and the call to CeedQFunctionAddInput.
jedbrown
commented
Jun 28, 2023
jeremylt
approved these changes
Jun 28, 2023
|
I'm not sure. What other issues are you aware of? I got a clean run of the standard tests. |
|
I think this was the last lingering one I knew about. |
jedbrown
force-pushed
the
jed/fix-asan-bugs
branch
4 times, most recently
from
400597c
to
4d8c181
Compare
jedbrown
force-pushed
the
jed/fix-asan-bugs
branch
from
4d8c181
to
fb65186
Compare
jeremylt
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: ‘snprintf’ output between 21 and 31 bytes into a destination of size 30
The assembly test had inconsistent ordering of arguments between the qfunction itself and the call to CeedQFunctionAddInput.