AtPoints - fix transpose basis apply on GPU #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatkins-dev
requested changes
Sep 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
Since I don't have HIP on my machine locally, I'll wait for Noether to give the green light |
Co-authored-by: Zach Atkins <[email protected]>
jeremylt
force-pushed
the
jeremy/at-points-transpose
branch
from
2495adf
to
9e511c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, now we skip the padded out points during the transpose basis application - this will change the computed strain energy and such so Ratel tests will need to be updated