Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCCA backend warning #820

Merged
merged 4 commits into from
Oct 1, 2021
Merged

Add OCCA backend warning #820

merged 4 commits into from
Oct 1, 2021

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Sep 30, 2021

See #816, the OCCA backend is not receiving regular maintenance, is less feature complete than the other backends, and is less performant. This change alerts users that this backend is experimental.

Copy link
Member

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable occa/openmp tests that are failing on noether?

include/ceed-backend.h Outdated Show resolved Hide resolved
@jeremylt
Copy link
Member Author

jeremylt commented Oct 1, 2021

The openmp mode was somewhat flakey iirc, so I don't object to disabling those tests in CI. I'll add that in the morning.

@jeremylt jeremylt force-pushed the jeremy/warn-occa branch 2 times, most recently from 0cce54e to 9a1d351 Compare October 1, 2021 14:57
@jeremylt
Copy link
Member Author

jeremylt commented Oct 1, 2021

Strange. I disabled the OCCA openmp backend for testing and the problem moved over to OCCA hip.

@jeremylt
Copy link
Member Author

jeremylt commented Oct 1, 2021

I adjusted the CI. I'm not sure what's going on, but now we just verify that the OCCA backend can build.

@jeremylt
Copy link
Member Author

jeremylt commented Oct 1, 2021

lv is stuck, but otherwise I think we're good to merge now

@jeremylt jeremylt added this to the v0.10 milestone Oct 1, 2021
@jeremylt jeremylt merged commit aae8ce3 into main Oct 1, 2021
@jeremylt jeremylt deleted the jeremy/warn-occa branch October 1, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants