Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isosurfacing_3 (new package) #6849

Open
wants to merge 356 commits into
base: master
Choose a base branch
from
Open

Isosurfacing_3 (new package) #6849

wants to merge 356 commits into from

Conversation

JulyCode
Copy link
Member

@JulyCode JulyCode commented Sep 15, 2022 •
edited by soesau
Loading

Summary of Changes

Extracting isosurfaces from scalar functions is a common method for generating 3D meshes. An isosurface is a subspace with equal values of the function.

ToDo:

  • Check branch size
  • TMC_functor::compute_edge_index() uses operator[] on cell_descriptor (violates concept)
  • Check Orthtree as partition for Marching Cubes after fixing compute_edge_index()

Extra:

  • Use Isosurfacing_3 in the demo (Isosurface_3_plugin)

Release Management

  • Affected package(s): Isosurfacing_3
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): Isosurfacing_3
  • License and copyright ownership: see feature

@JulyCode

This comment was marked as outdated.

Sign in to view
@MaelRL MaelRL marked this pull request as ready for review September 15, 2022 12:14
@afabri
Copy link
Member

afabri commented Sep 15, 2022

/build:v1

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature Work in progress labels Sep 15, 2022
@github-actions
Copy link

There was an error while building the doc:
/home/runner/work/cgal/cgal/Isosurfacing_3/include/CGAL/Octree_wrapper.h:330: warning: The following parameters of CGAL::Isosurfacing::Octree_wrapper::e_glIndex(const std::size_t &e, const std::size_t &i_idx, const std::size_t &j_idx, const std::size_t &k_idx, const std::size_t &depth) const are not documented:

@afabri

This comment was marked as outdated.

Sign in to view
@afabri
Copy link
Member

afabri commented Sep 15, 2022 •
edited
Loading

The data files have a problem with rights. I think they also need o+r
But more importantly they should be in the package Data so that we do not have millions of bunnies and skulls.

@MaelRL
Copy link
Member

MaelRL commented Jul 22, 2024

/build:v5

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6849/v5/Manual/index.html

@afabri afabri mentioned this pull request Aug 6, 2024
Open
@soesau
fixed includes
2533c70 
removing Octree_wrapper.h
updating copyright
@afabri
Copy link
Member

afabri commented Oct 4, 2024

Where do all these changes i'th to i-th come from in dozens of files which have nothing to do with iso surfacing ?

@MaelRL
Copy link
Member

MaelRL commented Oct 4, 2024

Where do all these changes i'th to i-th come from in dozens of files which have nothing to do with iso surfacing ?

efc43a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

@afabri afabri afabri requested changes

@MaelRL MaelRL MaelRL left review comments

@lrineau lrineau lrineau left review comments

@janetournois janetournois janetournois left review comments

Assignees
No one assigned
Labels
CHANGES.md not updated Feature gsoc gsoc-2022 Not yet approved The feature or pull-request has not yet been approved. Pkg::Isosurfacing_3 TODO Under Testing
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
9 participants
@JulyCode @afabri @sloriot @MaelRL @soesau @ange-clement @lrineau @janetournois @palliez