Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non existing link to open numerical library #7772

Closed
albert-github opened this issue Oct 9, 2023 · 7 comments · Fixed by #7816
Closed

Non existing link to open numerical library #7772

albert-github opened this issue Oct 9, 2023 · 7 comments · Fixed by #7816
Milestone

Comments

@albert-github
Copy link
Contributor

In Documentation/doc/Documentation/Usage.txt(Manual/usage.html) there is a link to:

http://alice.loria.fr/index.php/software/4-library/23-opennl.html

but this link does not exist anymore.

@afabri
Copy link
Member

afabri commented Oct 19, 2023

@albert-github
Copy link
Contributor Author

I got the impression that the reference is to the OpenNL library, isn't this a library on top of OpenNL and not the OpenNL library itself?

@afabri
Copy link
Member

afabri commented Oct 19, 2023

We have forked it some time ago. It is here. So the link is a link to where the official OpenNL is now.

@lrineau
Copy link
Member

lrineau commented Oct 20, 2023

Why does CGAL still use OpenNL, instead of Eigen? If CGAL_EIGEN3_ENABLED is defined, it seems that OpenNL is no longer used.

In my opinion, OpenNL could be removed completely from CGAL.

@afabri
Copy link
Member

afabri commented Oct 20, 2023

Here it is hard coded.
We could probably replace it with a least squares solver from Eigen.

@afabri
Copy link
Member

afabri commented Oct 20, 2023

In fact almost everything can be removed. There is a solver class that would remain but it calls the solver of the traits class which by default is the one using Eigen. However it might make sense to do a benchmark for the two.

@afabri
Copy link
Member

afabri commented Oct 20, 2023

When using Eigen it is 10 times faster. Also as there is a missing trailing underscore here that not even compiles in case Eigen was not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants