Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reshapeDimensions conflict in op_CSIApodize #101

Open
bellarude opened this issue Oct 17, 2022 · 2 comments
Open

reshapeDimensions conflict in op_CSIApodize #101

bellarude opened this issue Oct 17, 2022 · 2 comments

Comments

@bellarude
Copy link

bellarude commented Oct 17, 2022

Dear @jamienear

I have spotted an error whilst running an hamming filter on kspace on an MRSI dataset imported via twix.
FID-A version dated 6th October.

The way op_CSIApodize calls reshapeDimensions runs an error in getDimension.
To fix it requires simply to change line 14 in reshapeDimensions from permuteLabels(iDim) to permuteLabels{iDim}. However, I do not know whether this modification would generate conflicts elsewhere, where reshapeDimensions is called.

Hope it helps.
BW

Rudy

@bellarude
Copy link
Author

Just another minor mismatch is in getDimension, where adding

case('subSpecs')
            dimNumber = MRSIStruct.dims.subSpecs;

has fixed one error launched by op_CSICombineCoils.

BW

@brendo-k
Copy link
Contributor

Hey Rudy! Thank you opening an issue! I'll fix these problems and make a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants