Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICE Consortium visibility on government.github.com/community #308

Closed
phil-blain opened this issue Apr 26, 2019 · 15 comments
Closed

CICE Consortium visibility on government.github.com/community #308

phil-blain opened this issue Apr 26, 2019 · 15 comments

Comments

@phil-blain
Copy link
Member

I stumbled upon this page that lists government agencies doing work in the open on github. I thought it could be cool to feature the CICE Consortium on this page (I saw ACME is listed there, as well as a few other projects from the national labs). What do you guys think ?

@eclare108213
Copy link
Contributor

That's interesting. I think we should add our logo to the mix. I'm not sure which category to put it in, though. International? US Federal doesn't seem inclusive enough.

@phil-blain
Copy link
Member Author

I was thinking adding an "International" sub-section to the "Government-funded Research" section. I can issue a PR for that on that page if you want.

@phil-blain
Copy link
Member Author

The PR is here : github/government.github.com#766

@apcraig
Copy link
Contributor

apcraig commented Jun 6, 2019

I'm not entirely sure what's happening but the travis check is failing in the PR. You can look at the travis log and see an error. I don't know where it's coming from. It looks like travis passing is a requirement but I have not looked at their git process carefully.

@phil-blain
Copy link
Member Author

phil-blain commented Jun 6, 2019

There was an error because since I added an International subsection under Research and there already was one under Governments, so Jekyll generated different HTML tags with the same id's. I just modified the Jekyll file to account for that.

@duvivier
Copy link
Contributor

@phil-blain Do we need to do anything for this on our end? it looks like to be added to the governments page we'll need them to add it. Based on your PR there, it looks like you thought it was best to add a new subsection (International) rather than adding the CICE consortium under the US, Denmark, and Canada separately (if this would even be allowed).

@phil-blain
Copy link
Member Author

Yes, when the pull request is accepted the page will be updated. I thought it best to add it only once.

@duvivier
Copy link
Contributor

@phil-blain So the bottom line is we don't have to do anything on our end though. It's just once they accept the PR it'll be added to their page. Is this all correct?

@phil-blain
Copy link
Member Author

Yes,correct. We don't have anything more to do.

@apcraig
Copy link
Contributor

apcraig commented Aug 5, 2019

It looks like the PR sat too long and now is out of date with the base, github/government.github.com#766. What a pain. @phil-blain are you able to update? Should we give up?

@phil-blain
Copy link
Member Author

Yes I will update the PR with their latest master. As I wrote to Elizabeth this morning, I will do this after the sea-ice conference in Winnipeg in 2 weeks.

@phil-blain
Copy link
Member Author

I just updated the PR

@apcraig
Copy link
Contributor

apcraig commented Aug 13, 2019

Thanks @phil-blain! I get we can see if it gets stale again.

@phil-blain
Copy link
Member Author

They merged our PR ! https://government.github.com/community/#research

@eclare108213
Copy link
Contributor

Terrific! I just now looked at this, and we top the page! Thanks again @phil-blain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants