-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICE Consortium visibility on government.github.com/community #308
Comments
That's interesting. I think we should add our logo to the mix. I'm not sure which category to put it in, though. International? US Federal doesn't seem inclusive enough. |
I was thinking adding an "International" sub-section to the "Government-funded Research" section. I can issue a PR for that on that page if you want. |
The PR is here : github/government.github.com#766 |
I'm not entirely sure what's happening but the travis check is failing in the PR. You can look at the travis log and see an error. I don't know where it's coming from. It looks like travis passing is a requirement but I have not looked at their git process carefully. |
There was an error because since I added an International subsection under Research and there already was one under Governments, so Jekyll generated different HTML tags with the same id's. I just modified the Jekyll file to account for that. |
@phil-blain Do we need to do anything for this on our end? it looks like to be added to the governments page we'll need them to add it. Based on your PR there, it looks like you thought it was best to add a new subsection (International) rather than adding the CICE consortium under the US, Denmark, and Canada separately (if this would even be allowed). |
Yes, when the pull request is accepted the page will be updated. I thought it best to add it only once. |
@phil-blain So the bottom line is we don't have to do anything on our end though. It's just once they accept the PR it'll be added to their page. Is this all correct? |
Yes,correct. We don't have anything more to do. |
It looks like the PR sat too long and now is out of date with the base, github/government.github.com#766. What a pain. @phil-blain are you able to update? Should we give up? |
Yes I will update the PR with their latest master. As I wrote to Elizabeth this morning, I will do this after the sea-ice conference in Winnipeg in 2 weeks. |
I just updated the PR |
Thanks @phil-blain! I get we can see if it gets stale again. |
They merged our PR ! https://government.github.com/community/#research |
Terrific! I just now looked at this, and we top the page! Thanks again @phil-blain |
I stumbled upon this page that lists government agencies doing work in the open on github. I thought it could be cool to feature the CICE Consortium on this page (I saw ACME is listed there, as well as a few other projects from the national labs). What do you guys think ?
The text was updated successfully, but these errors were encountered: