Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cyclostrophic a model parameter in the Holland windfield model interface #897

Open
peanutfun opened this issue Jun 19, 2024 · 0 comments · May be fixed by #936
Open

Make cyclostrophic a model parameter in the Holland windfield model interface #897

peanutfun opened this issue Jun 19, 2024 · 0 comments · May be fixed by #936
Assignees
@spjuhel
Labels
accepting pull request Contribute by raising a pull request to resolve this issue! enhancement

Comments

@peanutfun
Copy link
Member

This follows-up on a discussion in #846 (comment).

Is your feature request related to a problem? Please describe.
cyclostrophic is a parameter in all but the Holland 2010 windfield models. It is forced to False, but the Holland 2010 model is always cyclostrophic, and choosing False does not make sense here.

Describe the solution you'd like

  1. cyclostrophic should become a model_kwarg in TropCyclone.from_tracks. It should have a "variable" default: True for Holland 2010, False for all other models.
  2. Using cyclostrophic=False for Holland 2010 should result in an error.

Describe alternatives you've considered
None

Additional context
None

@ThomasRoosli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spjuhel spjuhel

Labels
accepting pull request Contribute by raising a pull request to resolve this issue! enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shift cyclostrophic argument to model_kwargs in from_tracks CLIMADA-project/climada_python
2 participants
@spjuhel @peanutfun