-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25 tests failing with climada version 5 and conda #946
Comments
Running the tests also create the following files within the directory, which are not git-ignored:
This surprises me, so maybe it hints at some mis-configuration (?) - in any case I thought I'd report this here as well. |
@bguillod thanks for the report. It must be something, as we don't encounter this i.g. while running exactly the same installation steps. To exclude an issue with the repo - what is the outupt of |
Thanks @emanuel-schmid for your reply, and I agree on this point. Please note that one of my colleague encounters the exact same issue (also on MacOS with Apple Silicon Processor). Output of
Output of
|
Thanks! Now it's clear that the repository can't be blamed. |
We tried out a bit out here and we are 3 people with M1 or M3 Macs experiencing roughly the same tests failing. We are unable to install an environment in which those all pass. I'm curious to see if you get the same issues on your end. It can't be due to the use of |
🤔 Hm. Rather not. I went through the errors and found a reasonable explanation to most of them: not unusual. floating point discrepancy between os.
to be investigated. missing BlackMarble file. automated download failed. perhaps config?
not unusual. broken connection.
missing gpw_v4_population_count_rev11_2020_30_sec file. no automated download for this file. download and run again.
not unusual. most likely world bank data download failed.
irrelevant. not part of test suit. run
|
So all in all it boils down to one interesting finding. the automated blackmarble file download fails. python -m unittest climada.test.test_litpop_integr.LitPopExposure.switzerland300_pass ? |
The output would be this:
But I assume you actually wanted me to run this instead?
|
As for the potentially config-related issue, I actually wonder if there are remnants from quite old climada installations I might have had which I should clean up to start from a cleaner state. However looking at my home (.config and climada/conf) it doesn't seem to be the case. Unless maybe old files are still stored in the |
That could indeed be the case! To see whether this is the case you could temporarily rename the |
😁 exactly! Then I'd just remove the file |
Describe the bug
Following an update of conda, I have installed the climada environment (as a developper, i.e. following the advanced instructions). However, I used conda instead of mambda (however I have run
conda config --set solver libmamba
so behind the scene mamba is running), and I adjusted the instructions to pick python 3.11 instead of 3.9. The installation seems to work fine, but 25 unit tests fail (!). You will find the summary logs below.To Reproduce
Steps to reproduce the behavior/error:
conda update -n base -c conda-forge --all
conda create -n climada_env "python=3.11.*"
conda env update -n climada_env -f requirements/env_climada.yml
conda activate climada_env
python -m pip install -e ./
python -m unittest climada.engine.test.test_impact
(this already fails one testclimada.engine.test.test_impact.TestRPmatrix.test_local_exceedance_imp_pass
, exactly as pointed out in RewriteTestRPmatrix::test_local_exceedance_imp_pass
to not rely on loading data #915)conda
instead ofmambda
, including climada_petals installation, etc.pytest .
from within the climada_python folder (develop branch). There, a total of 25 unit tests fail.Expected behavior
All tests should pass.
Climada Version: current develop branch (5.0.1.dev0)
System Information (please complete the following information):
Additional context
This does not seem to happen in docker.
Here is the short test summary info output:
The text was updated successfully, but these errors were encountered: