Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome look #74

Open
sylware opened this issue Oct 13, 2021 · 24 comments
Open

gnome look #74

sylware opened this issue Oct 13, 2021 · 24 comments

Comments

@sylware
Copy link

sylware commented Oct 13, 2021

I wonder if my git build is working: I did try many "javascript" sites, but I get 1 empty line most of the time.

Are there test "javascript" sites known to work I could test my build against?

@eklhad
Copy link
Collaborator

eklhad commented Oct 13, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 13, 2021

Just tested nasa site, and I get 4 lines with round brackets. I guess my build is broken someway and I'll have to figure out why.

@eklhad
Copy link
Collaborator

eklhad commented Oct 13, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 13, 2021

And yes, the web is now "trusted" by ultra-heavy/tons of devs browsers (horrible c++ kludges).
This is a serious issue which should be handled by regulation and by enforcing noscript/basic (x)html interop for critical sites.
Coding a lean C89 coded and full web engine without 1000 devs is not reasonable.
edbrowse could mitigate this issue a lot if it achieves good compatibilty in spite of not being graphical.

@sylware
Copy link
Author

sylware commented Oct 13, 2021

yeah, the nasa site is working with the 3.8.0 static build, but not with my build of git edbrowse.

@eklhad
Copy link
Collaborator

eklhad commented Oct 13, 2021 via email

@eklhad
Copy link
Collaborator

eklhad commented Oct 13, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 13, 2021

huho... not wanted to be pushy or anything, just wanted to know if it was my build or the current state of git edbrowse. Ofc, I am not expecting the git edbrowse to work all the time, no worries :)

@eklhad
Copy link
Collaborator

eklhad commented Oct 13, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 13, 2021

git pulled but this is what I feared: I get the same result, namely only a few round brackets and that's it.

@eklhad
Copy link
Collaborator

eklhad commented Oct 13, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 14, 2021

I am manually building libpcre2, quickjs and edbrowse. Very probably, I did not configure properly something.
I am posting the log on a noscript/basic (x)html pastebin if you want to have a look (but this is probably me who did something wrong) : https://paste.c-net.org/PayoffOptions
(your email address is ****)

@eklhad
Copy link
Collaborator

eklhad commented Oct 14, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 14, 2021

Ouch. I built a git quickjs (from yesterday). I'll investigate this stack size (I smell a configure mistake).

@eklhad
Copy link
Collaborator

eklhad commented Oct 14, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 14, 2021

I did put 1GiB of max stack size in quickjs which still overflows. I am about to look at your work around.

@eklhad
Copy link
Collaborator

eklhad commented Oct 14, 2021 via email

@sylware
Copy link
Author

sylware commented Oct 14, 2021

Skimming the bug, I don't understand it. I guess I have to seriously dive into this issue. Either the git version of quickjs broke edbrowse, or, very probably, I configure the build wrong.

@sylware
Copy link
Author

sylware commented Oct 14, 2021

found the issue: in quickjs there are several macro variables to control the stack size, I did modifiy the MAX, but not the default allocated. I did put 1GiB in the default stack size, and voilà, working.

Then, the default stack size in quickjs (and maybe the other stack size related variables) must be adjusted or nearly no sites will work.

I guess this should be made explicit in edbrowse build documentation.

@eklhad
Copy link
Collaborator

eklhad commented Oct 14, 2021 via email

@CMB
Copy link
Owner

CMB commented Oct 19, 2021

Hi,
I don't do anything special with quickjs configuration, it's a stock
build. I link the static executables with musl.

Since there's interest in static builds from git, I'm working on
containerizing and automating that build procedure. Ideally, any time someone
pushes to the edbrowse git repo, a new snapshot of the static executables will
show up on edbrowse.org, but we aren't there yet.

@sylware
Copy link
Author

sylware commented Oct 24, 2021

wow, this is super weird. Then it may be related to quickjs itself or same nastier interaction. I usually use git libpcre2/quickjs/tidyhtml of the day.

@sylware
Copy link
Author

sylware commented Aug 19, 2022

just tried a recent edbrowse build, almost could download a x11 cursor theme!

@sylware
Copy link
Author

sylware commented Apr 27, 2023

I tested today: once I get to a x11 mouse cursor theme, the javascript will delete after a short time everything and I'll end up with a few buttons which does nothing.

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants