Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using readline.h #80

Open
kyx0r opened this issue May 17, 2022 · 3 comments
Open

stop using readline.h #80

kyx0r opened this issue May 17, 2022 · 3 comments

Comments

@kyx0r
Copy link

kyx0r commented May 17, 2022

At least mention that it's required or even better vendor it.

@ryandesign
Copy link

I would not recommend vendoring a common library like readline; it should be available in any distribution and if edbrowse is packaged in such a distribution the packagers would want to use their readline, not a potentially out of date bundled version.

But mentioning all requirements in the documentation is a good idea, and making the use of readline optional is a reasonable request.

@eklhad
Copy link
Collaborator

eklhad commented Oct 11, 2022 via email

@martinetd
Copy link
Contributor

"vendoring" would mean including all readline sources inside the edbrowse repository and building it together with edbrowse.
We do not do that (and there shouldn't be any reason to ever do that), just mentioning it as a requirement in the README should be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants