From 39e51152e8156221d2c5b0543410907dfbfd6c8b Mon Sep 17 00:00:00 2001 From: laurenkrugen-navapbc <126501259+laurenkrugen-navapbc@users.noreply.github.com> Date: Tue, 13 Jun 2023 10:54:59 -0700 Subject: [PATCH] BCDA-6873: updated test IPs to non-routable IPs (#852) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## đŸŽĢ Ticket https://jira.cms.gov/browse/BCDA-6873 ## 🛠 Changes Updated the test IP addresses so that they are non-sensitive/non-routable. ## ℹī¸ Context for reviewers Updating IP addresses in tests added in [PR #849](https://github.com/CMSgov/bcda-app/pull/849) ## ✅ Acceptance Validation ran tests locally and CI. ## 🔒 Security Implications - [ ] This PR adds a new software dependency or dependencies. - [ ] This PR modifies or invalidates one or more of our security controls. - [ ] This PR stores or transmits data that was not stored or transmitted before. - [ ] This PR requires additional review of its security implications for other reasons. If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval. --- bcda/nrpgx/nrpgx_test.go | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/bcda/nrpgx/nrpgx_test.go b/bcda/nrpgx/nrpgx_test.go index 128758658..f7fc0232b 100644 --- a/bcda/nrpgx/nrpgx_test.go +++ b/bcda/nrpgx/nrpgx_test.go @@ -99,29 +99,29 @@ func TestParseDSN(t *testing.T) { // key,value pairs // #11 { - dsn: "host=1.2.3.4 port=1234 dbname=mydb", - expHost: "1.2.3.4", + dsn: "host=0.0.0.0 port=1234 dbname=mydb", + expHost: "0.0.0.0", expPortPathOrID: "1234", expDatabaseName: "mydb", }, // #12 { - dsn: "host =1.2.3.4 port= 1234 dbname = mydb", - expHost: "1.2.3.4", + dsn: "host =0.0.0.0 port= 1234 dbname = mydb", + expHost: "0.0.0.0", expPortPathOrID: "1234", expDatabaseName: "mydb", }, // #13 { - dsn: "host = 1.2.3.4 port=\t\t1234 dbname =\n\t\t\tmydb", - expHost: "1.2.3.4", + dsn: "host = 0.0.0.0 port=\t\t1234 dbname =\n\t\t\tmydb", + expHost: "0.0.0.0", expPortPathOrID: "1234", expDatabaseName: "mydb", }, // #14 { - dsn: "host ='1.2.3.4' port= '1234' dbname = 'mydb'", - expHost: "1.2.3.4", + dsn: "host ='0.0.0.0' port= '1234' dbname = 'mydb'", + expHost: "0.0.0.0", expPortPathOrID: "1234", expDatabaseName: "mydb", }, @@ -140,20 +140,20 @@ func TestParseDSN(t *testing.T) { }, // #17 { - dsn: "host=1.2.3.4 hostaddr=5.6.7.8", + dsn: "host=0.0.0.0 hostaddr=5.6.7.8", expHost: "5.6.7.8", expPortPathOrID: "5432", }, // #18 { - dsn: "hostaddr=5.6.7.8 host=1.2.3.4", + dsn: "hostaddr=5.6.7.8 host=0.0.0.0", expHost: "5.6.7.8", expPortPathOrID: "5432", }, // #19 { - dsn: "hostaddr=1.2.3.4", - expHost: "1.2.3.4", + dsn: "hostaddr=0.0.0.0", + expHost: "0.0.0.0", expPortPathOrID: "5432", }, // #20