Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code in src/upgrades/1.1.0/user_post_count_per_tid.js #28

Open
mthani2 opened this issue Sep 1, 2024 · 4 comments · May be fixed by #29
Open

Refactoring code in src/upgrades/1.1.0/user_post_count_per_tid.js #28

mthani2 opened this issue Sep 1, 2024 · 4 comments · May be fixed by #29
Assignees

Comments

@mthani2
Copy link

mthani2 commented Sep 1, 2024

Refactor this code to not nest functions more than 4 levels deep.
src/upgrades/1.1.0/user_post_count_per_tid.js

@mthani2
Copy link
Author

mthani2 commented Sep 1, 2024

I would like to work on this please!

Copy link

github-actions bot commented Sep 1, 2024

Great! I assigned you (@mthani2) to the issue. Have fun working on it!

@EduardoFF
Copy link
Contributor

The current tests do not cover this file. Therefore, you have two options to complete the last part of P1B:

(a) Write tests from scratch to cover that file OR

(b) Select another file currently covered by tests (under src/) that is NOT fully covered and do the following:

  • Increase the coverage of the file by at least one line.
  • Commit your changes to the same branch referenced in the PR.
  • For the final part of the task (manual testing), activate at least one function of the file you selected from the user interface (UI).

@mthani2
Copy link
Author

mthani2 commented Sep 3, 2024

Increasing coverage in src/user/reset.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants