Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code src/upgrades/1.0.0/chat_upgrade.js #32

Closed
aattiyah opened this issue Sep 1, 2024 · 3 comments
Closed

Refactoring code src/upgrades/1.0.0/chat_upgrade.js #32

aattiyah opened this issue Sep 1, 2024 · 3 comments
Assignees

Comments

@aattiyah
Copy link

aattiyah commented Sep 1, 2024

Refactor this code to not nest functions more than 4 levels deep.

src/upgrades/1.0.0/chat_upgrade.js

@aattiyah
Copy link
Author

aattiyah commented Sep 1, 2024

I would like to work on this please!

Copy link

github-actions bot commented Sep 1, 2024

Great! I assigned you (@aattiyah) to the issue. Have fun working on it!

@EduardoFF
Copy link
Contributor

The current tests do not cover this file. Therefore, you have two options to complete the last part of P1B:

(a) Write tests from scratch to cover that file OR
(b) Select another file currently covered by tests (under src/) that is NOT fully covered and do the following:

  • Increase the coverage of the file by at least one line.
  • Commit your changes to the same branch referenced in the PR.
  • For the final part of the task (manual testing), activate at least one function of the file you selected from the user interface (UI).

@aattiyah aattiyah closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants