Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code in src/groups/update.js #43

Open
mohamed-elzeni opened this issue Sep 2, 2024 · 2 comments · May be fixed by #81
Open

Refactoring code in src/groups/update.js #43

mohamed-elzeni opened this issue Sep 2, 2024 · 2 comments · May be fixed by #81
Assignees
@mohamed-elzeni

Comments

@mohamed-elzeni
Copy link
Member

mohamed-elzeni commented Sep 2, 2024 •
edited
Loading

Issue: The function Groups.update in file src/groups/update.js has a complex control flow, causing its Cognitive Complexity on SonarCloud to reach 27, which is higher than the allowed 15.

Task: The code in this function should be refactored into smaller, easier-to-manage pieces to reduce its Cognitive Complexity from 27 to the 15 allowed.
@mohamed-elzeni
Copy link
Member Author

I would like to work on this please!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Great! I assigned you (@mohamed-elzeni) to the issue. Have fun working on it!

@mohamed-elzeni mohamed-elzeni linked a pull request Sep 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohamed-elzeni mohamed-elzeni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor code in src/groups/update.js mohamed-elzeni/NodeBB
1 participant
@mohamed-elzeni