Refactoring code to reduce cognitive complexity from 16 to 15 in src/user/settings.js #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15 and fixed some style issues
Pull Request Test Coverage Report for Build 10705501656Details
💛 - Coveralls |
added 2 commits
September 2, 2024 17:10
SarimFaraz
changed the title
…n test, and checked manual testing by checking user settings
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #13
The purpose of this task is to reduce the cognitive complexity of the file src/user/settings.js
I broke the code down and made two new functions to reduce the cognitive complexity:
validatePaginationValue: This function checks if a given pagination value is within the acceptable range. If the value is not valid, it throws an error.
validateLanguage: This function checks if a given language code is included in the list of valid language codes. If the language code is not valid, it throws an error.
This makes the code easier to read, follow, and fixes the issues.