src/flags.js (Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.) #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #10
Resolves #10
File name: src/flags.js
Refactoring the flag.validate function to reduce complexity by removing the nest if statements. This reduces the complexity from 18 to 15. Fix Cognitive Complexity in src/flags.js.
Changes to the original code to reduce complexity:
Removed unnecessary else if statement: I removed the else if conditions because each of the conditionals contained throws, which would automatically make you return and leave the function. Through doing this, I was able to remove deep nested if statements which reduced its complexity.