Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in src/messaging/data.js to remove duplicated code blocks. #8

Open
jdufitum opened this issue Aug 29, 2024 · 2 comments · May be fixed by #92
Open

Refactor code in src/messaging/data.js to remove duplicated code blocks. #8

jdufitum opened this issue Aug 29, 2024 · 2 comments · May be fixed by #92
Assignees

Comments

@jdufitum
Copy link

This issue involves refactoring the code in "src/messaging/data.js" to eliminate duplicated code blocks in a conditional structure. According to SonarCloud, the branches on lines 83, 86, and 89 contain identical code blocks. Two branches in a conditional structure should not have exactly the same implementation, as this reduces the code's maintainability and may indicate a design flaw.

The relevant code block begins around line 83 in the "src/messaging/data.js" file. The task is to refactor the code to ensure that each branch has distinct and meaningful logic, thereby improving code quality and adherence to best practices.

@jdufitum
Copy link
Author

I would like to work on this please!

Copy link

Great! I assigned you (@jdufitum) to the issue. Have fun working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant