Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code in src/batch.js #9

Open
Hakaabi opened this issue Aug 29, 2024 · 3 comments
Open

Refactoring code in src/batch.js #9

Hakaabi opened this issue Aug 29, 2024 · 3 comments
Assignees

Comments

@Hakaabi
Copy link

Hakaabi commented Aug 29, 2024

I am refactoring the function 'processSortedSet' in file 'batch.js' under folder 'src'.

I added a helper function named 'processIsFunction' to deal with the cognitive complexity warning from line 17. This single helper method was able to solve all the errors concerning cognitive complexity in the code.

NodeBB version

No response

NodeBB git hash

No response

NodeJS version

No response

Installed NodeBB plugins

No response

Database type

No response

Database version

No response

Exact steps to cause this issue

No response

What you expected

No response

What happened instead

No response

Anything else?

No response

@Hakaabi Hakaabi added the bug Something isn't working label Aug 29, 2024
@Hakaabi
Copy link
Author

Hakaabi commented Aug 29, 2024

I would like to work on this please!

Copy link

Great! I assigned you (@Hakaabi) to the issue. Have fun working on it!

@EduardoFF EduardoFF removed the bug Something isn't working label Aug 29, 2024
@EduardoFF
Copy link
Contributor

This type of issue shouldn't be labeled as a bug. It pertains to solving a problem that affects code quality rather than functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants