forked from CMU-17313Q/cmu-17313q-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated testing for the bug-log button in admin dashboard navigation (User Story 2) #45
Open
akobaidan
wants to merge
8
commits into
f24
Choose a base branch
from
testing-bug-log-button
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akobaidan
added
backend
main code is written in backend
Test
This tests features that were implemented
labels
Oct 20, 2024
This was
linked to
issues
Oct 20, 2024
Pull Request Test Coverage Report for Build 11425011603Details
💛 - Coveralls |
aattiyah
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
lhitmi
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good and cover all relevant functionalities!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
test/controllers-admin.js
to test the functionality of bug-log button in admin dashboard navigation.The test
should load admin dashboard with bug-logs
expands on the existing test ofshould load admin dashboard
by checking for the loading of the route/admin/dashboard/bug-logs
. In doing so, the test verifies that the button is in the navigation of the admin dashboard and ensures that the page is loadable with the correct view filesrc/views/admin/dashboard/bug-logs.tpl
The test contributes to having comprehensive coverage that validates the new functionality within the admin dashboard for issue #17.
This test closes issue #44.